Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] replace get-libwasm-version.py with a bash script #7889

Closed
wants to merge 6 commits into from
Closed

[chore] replace get-libwasm-version.py with a bash script #7889

wants to merge 6 commits into from

Conversation

ArtGinn
Copy link

@ArtGinn ArtGinn commented Jan 27, 2025 •
edited
Loading

Description

closes: #7885

Step to run:

  • docker build -t wasm-version-checker -f script/Dockerfile .
  • docker run --rm wasm-version-checker

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

gjermundgaraba
gjermundgaraba requested changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
A couple of notes.

  1. The script does not have to do be exactly like the python version. We really only use the version.
  2. Any usage of the python script would also have to be updated and tested with the new script.

Did you make any attempt to see if this was possible to do in the Dockerfile without having to have the argument and a script at all? If possible, it would be better :)

@ArtGinn
Copy link
Author

ArtGinn commented Jan 28, 2025

Did you make any attempt to see if this was possible to do in the Dockerfile without having to have the argument and a script at all? If possible, it would be better :)

Let me try this way 😂👌🏻 @gjermundgaraba

@ArtGinn
Copy link
Author

ArtGinn commented Feb 2, 2025

hi @gjermundgaraba, I just updated with dockerfile could you check it?

@gjermundgaraba
Copy link
Contributor

It should be changing the 08-wasm Dockerfile. Please look at the Dockerfile and make sure the make build-docker-wasm works correctly.

@ArtGinn ArtGinn closed this Feb 11, 2025
@ArtGinn ArtGinn deleted the replace_get_libwasm_version branch February 11, 2025 04:48
@ArtGinn
Copy link
Author

ArtGinn commented Feb 11, 2025

Hi @gjermundgaraba, I can't reopen this pr so i created a new pr here, could you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjermundgaraba gjermundgaraba gjermundgaraba requested changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@srdtrk srdtrk Awaiting requested review from srdtrk srdtrk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace get-libwasm-version.py script
2 participants
@ArtGinn @gjermundgaraba